Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme-check plugin master branch instead of a particular PR #8200

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

matiasbenedetto
Copy link
Member

@matiasbenedetto matiasbenedetto commented Sep 24, 2024

What?

Use theme-check plugin master branch instead of a particular PR

Why?

We were using a particular PR that included the wp-cli integration to run the theme-check plugin in the CI environment. That branch is merged now, so we can use master.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

As a side note, looks like we should probably only run the WordPress Theme Check workflow on PRs that change files in themes - maybe check for file changes in subfolders, with an exclude list for folders like .github?

@matiasbenedetto
Copy link
Member Author

matiasbenedetto commented Sep 24, 2024

As a side note, looks like we should probably only run the WordPress Theme Check workflow on PRs that change files in themes - maybe check for file changes in subfolders, with an exclude list for folders like .github?

Yes, that's in progress in #8198

@matiasbenedetto matiasbenedetto merged commit c12ea9c into trunk Sep 24, 2024
2 of 3 checks passed
@matiasbenedetto matiasbenedetto deleted the update/use-theme-check-master-branch branch September 24, 2024 13:39
@mikachan
Copy link
Member

mikachan commented Sep 24, 2024

Yes, that's in progress in #8198

Ah sorry, I hadn't seen this PR. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants